Travis CIからGithub Actionsに変更 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaxyz
requested review from
shimizukawa,
tokibito,
ae35bp,
posbin and
mtb-beta
shimizukawa
approved these changes
Mar 10, 2022
| @@ -115,3 +115,11 @@ deps = | |||
| flake8 | |||
| commands = | |||
| flake8 bpmappers/ | |||
|
|
|||
There was a problem hiding this comment.
メモ: 編集範囲外の [testenv:py37-dj31] 等のセクションもまとめられそうですが、またいずれ。
kemu3007
reviewed
Mar 10, 2022
| # push と pull request イベント毎にGtihubのWorkflowを起動する | ||
| on: | ||
| - push | ||
| - pull_request |
There was a problem hiding this comment.
pushとpull_requestで絞り込みせずに起動させた場合pull_request時に2回同じテストが実行されてしまいます。
なのでpull_requestのopened, syncronize & push masterにするかpushのみに条件を絞った方が良いです。
There was a problem hiding this comment.
同じテストが同時に2回走ってるぽいのは気になってました。
検討します。
There was a problem hiding this comment.
いったん issueにしました #8
別PRで対応できればと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目的
作業内容
レビューしてほしいところ