Automatically map all statuses that have the same name in different l…

…ifecycles
bestpractical · Feb 6, 2024 · 46fe0f3 · 46fe0f3
1 parent ce47e76
commit 46fe0f3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/lib/RT/Lifecycle.pm b/lib/RT/Lifecycle.pm
@@ -546,7 +546,7 @@ sub MoveMap {
     my $from = shift; # self
     my $to = shift;
     $to = RT::Lifecycle->Load( Name => $to, Type => $from->Type ) unless ref $to;
-    return $LIFECYCLES{'__maps__'}{ $from->Name .' -> '. $to->Name } || {};
+    return $LIFECYCLES_CACHE{'__maps__'}{ $from->Name .' -> '. $to->Name } || {};
 }
 
 =head3 HasMoveMap
@@ -655,6 +655,7 @@ sub FillCache {
     %LIFECYCLES_CACHE = %LIFECYCLES = %$map;
     $_ = { %$_ } foreach values %LIFECYCLES_CACHE;
 
+    my %all_statuses;
     foreach my $name ( keys %LIFECYCLES_CACHE ) {
         next if $name eq "__maps__";
         my $lifecycle = $LIFECYCLES_CACHE{$name};
@@ -714,6 +715,7 @@ sub FillCache {
         my %seen;
         @statuses = grep !$seen{ lc $_ }++, @statuses;
         $lifecycle->{''} = \@statuses;
+        push @{$all_statuses{$type}{lc $_} ||= []}, $name for @statuses;
 
         unless ( $lifecycle->{'transitions'}{''} ) {
             $lifecycle->{'transitions'}{''} = [ grep lc $_ ne 'deleted', @statuses ];
@@ -760,6 +762,20 @@ sub FillCache {
         }
     }
 
+
+    # Automatically map statuses with the same name
+    for my $type ( keys %all_statuses ) {
+        for my $status ( keys %{$all_statuses{$type}} ) {
+            my @lifecycles = @{ $all_statuses{$type}{$status} };
+            for my $from ( @lifecycles ) {
+                for my $to ( @lifecycles ) {
+                    next if $from eq $to;
+                    $LIFECYCLES_CACHE{'__maps__'}{"$from -> $to"}{$status} ||= $status;
+                }
+            }
+        }
+    }
+
     for my $type (keys %LIFECYCLES_TYPES) {
         for my $category ( qw(initial active inactive), '' ) {
             my %seen;

diff --git a/t/web/lifecycle_mappings.t b/t/web/lifecycle_mappings.t
@@ -182,6 +182,18 @@ diag "Test advanced mappings";
     is_deeply(
         $maps,
         {
+            'triage -> sales-engineering' => {
+                'resolved' => 'resolved'
+            },
+            'default -> sales-engineering' => {
+                'rejected' => 'rejected',
+                'resolved' => 'resolved',
+                'deleted'  => 'deleted',
+                'stalled'  => 'stalled'
+            },
+            'sales-engineering -> triage' => {
+                'resolved' => 'resolved'
+            },
             'sales-engineering -> default' => {
                 'rejected'    => 'rejected',
                 'resolved'    => 'resolved',
@@ -194,7 +206,7 @@ diag "Test advanced mappings";
         'Correct current value'
     );
 
-    $maps->{'default -> sales-engineering'} = { 'new' => 'sales', };
+    $maps->{'default -> sales-engineering'}{new} = 'sales';
 
     $m->submit_form_ok(
         {