Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Shredder attachments regex #242

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

federicobaldo
Copy link

In order to match also _ and - characters.

@sunnavy
Copy link
Member

sunnavy commented Jan 24, 2018

thanks for the commit.

"-" part looks good to me.

note that "\w" already matches "_", so it's not necessary to explicitly add "_".

@federicobaldo
Copy link
Author

Thanks, applied your suggestion.

@sunnavy
Copy link
Member

sunnavy commented Jan 24, 2018

To make the merge more clear, maybe you can combine the 2 commits instead?
thanks!

In order to match also - character.
@federicobaldo
Copy link
Author

Done, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants