Subject tag in email to #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, you can create a ticket (via the REST interface) with a Cc of => [4], which will unexpectedly cause the ticket to be CC'd to the entire group (all privilidged users is always ID bestpractical#4). This is obviously unexpected, and in a large multi-tenant shared RT situation, all privilidged users seeing a specific ticket is really really bad.. If for some reason this API needs to stay, then I strongly think it should refuse to create CCs for the default privilidged / everyone groups, as this is never what you want, and always bad... Also, the user interface is completely unable to handle tickets which have a group CC'd in - they instead list a blank space, and checking the checkbox doesn't work to remove the group. So even after we'd worked out what was going on, we weren't able to undo it without manual database hacking. If the numeric API _is_ meant to be supported, then it either needs to expand group ID into a list of user IDs and add these, or group ID#s need to be disallowed, or the interface needs to correctly support the removal of groups from tickets.
As per bestpractical#28, however for To addresses
|
we already support "the interface needs to correctly support the removal of groups from tickets.", so I assume the first commit is not necessary any more. the 2nd commit lacks the document of the new option and it seems not quite flexible as subject tag is fixed to be the first %s, so maybe it's good to make a local customization instead of coring it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow per queue tags to be used in email 'To' addresses.