Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear X-Amzn-Trace-Id in httbin.org responses #202

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

jhatler
Copy link
Contributor

@jhatler jhatler commented Dec 23, 2023

The httbin.org service returns a X-Amzn-Trace-Id header in its responses, which is different for each request. This causes the tests to fail. This clears the header before comparing responses.

Refs: #184, #190
Signed-off-by: Jaremy Hatler [email protected]

The httbin.org service returns a X-Amzn-Trace-Id header in its
responses, which is different for each request. This causes the
tests to fail. This clears the header before comparing responses.

Refs: betamaxpy#184, betamaxpy#190
Signed-off-by: Jaremy Hatler <[email protected]>
@jhatler
Copy link
Contributor Author

jhatler commented Dec 23, 2023

I've successfully tested this locally by running tox -e py on Ubuntu 22.04.

Additionally, #205 and #206 were merged on my fork (fixing the tox checks) so the other python targets could be tested. The tox checks passed successfully.

jhatler#4

@sigmavirus24 sigmavirus24 merged commit c75cfc7 into betamaxpy:main Dec 29, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants