Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TargetCamera to UiTargetCamera #17403

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Rename TargetCamera to UiTargetCamera #17403

wants to merge 5 commits into from

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 16, 2025 •
edited
Loading

Objective

It's not immediately obvious that TargetCamera only works with UI node entities. It's natural to assume from looking at something like the multiple_windows example that it will work with everything.

Solution

Rename TargetCamera to UiTargetCamera.

Migration Guide

TargetCamera has been renamed to UiTargetCamera.

@ickshonpe ickshonpe changed the title Renamed TargetCamera to UiTargetCamera Rename TargetCamera to UiTargetCamera Jan 16, 2025
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 16, 2025
@rparrett rparrett added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@ickshonpe ickshonpe force-pushed the rename-target-camera branch from 62db864 to c9da20f Compare January 16, 2025 13:28
alice-i-cecile
alice-i-cecile approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that this isn't more unified, but making this clear is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @alice-i-cecile @rparrett