Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

........ #26

Open
wants to merge 600 commits into
base: master
Choose a base branch
from
Open

........ #26

wants to merge 600 commits into from

Conversation

huynh922
Copy link

..........

christroutner and others added 30 commits November 18, 2019 13:47
These @types are needed if a TS project is rebuilding bitbox-sdk from source.  This would be the case even if .d.ts files were published instead of .ts files since the .d.ts file would still have references to these dependent types.

Also, on a separate note. Maybe something to consider in a future release is to publish `.d.ts` files instead of the `.ts` files.  I'm currently planning on doing this for `slpjs` soon, but right now I'm struggling with some strange issue preventing me from doing so.
This patch fixes the issue I get when I run `tsc` in a ts project that depends on recent versions of bitbox-sdk:

  node_modules/bitbox-sdk/lib/Crypto.ts:1:1
    1 import * as randomBytes from "randombytes"
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Type originates at this import. A namespace-style import cannot be called or constructed, and will cause a failure at runtime. Consider using a default import or import require here instead.
The default typescript tsconfig.json file generated from `tsc --init` has this property set to true.  If there are no build errors or other failures resulting from this update, then it would probably be easier for other users to update this.
fix randomBytes import for same reason as Crypto.ts
fix(typescript): Updates to TS types
added multi-output transaction example
Adding custom server ENV VAR for targeting specific servers with inte…
add documentation from developer.bitcoin.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants