fix(analyzer): suppression comment fails with inner comments in funct…

…ions
biomejs · Dec 9, 2024 · ff1d948 · ff1d948
1 parent 3914be8
commit ff1d948
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/...geset/fixanalyzer_suppression_comment_fails_with_inner_comments_in_functions.md b/...geset/fixanalyzer_suppression_comment_fails_with_inner_comments_in_functions.md
@@ -0,0 +1,5 @@
+---
+biome_analyze: patch
+---
+
+# fix(analyzer): suppression comment fails with inner comments in functions
diff --git a/crates/biome_analyze/src/lib.rs b/crates/biome_analyze/src/lib.rs
@@ -447,22 +447,15 @@ where
             let suppression = match suppression {
                 Some(suppression) => Some(suppression),
                 None => {
-                    let index =
-                        self.suppressions
-                            .line_suppressions
-                            .binary_search_by(|suppression| {
-                                if suppression.text_range.end() < entry.text_range.start() {
-                                    Ordering::Less
-                                } else if entry.text_range.end() < suppression.text_range.start() {
-                                    Ordering::Greater
-                                } else {
-                                    Ordering::Equal
-                                }
-                            });
-
-                    index
-                        .ok()
-                        .map(|index| &mut self.suppressions.line_suppressions[index])
+                    let index = self.suppressions.line_suppressions.partition_point(|suppression| {
+                        suppression.text_range.end() < entry.text_range.start()
+                    });
+
+                    if index >= self.suppressions.line_suppressions.len() {
+                        None
+                    } else {
+                        Some(&mut self.suppressions.line_suppressions[index])
+                    }
                 }
             };