Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update next README.md #4865

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

chore: update next README.md #4865

wants to merge 1 commit into from

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Jan 9, 2025

Summary

I plan to make next the default branch here on github.

Test Plan

N/A

@arendjr
Copy link
Contributor

arendjr commented Jan 9, 2025

Rather than changing the default, can’t we just create a new branch (say, maintenance-1.x) off main and then merge next?

The main advantage would be that it can stay like that going forward and we wouldn’t have a confusing default.

@ematipico
Copy link
Member Author

We could, however that could be a breaking change for people that use our crates from git.

Not a biggy, just wanted to have a safe approach

@arendjr
Copy link
Contributor

arendjr commented Jan 9, 2025

I don't think I've ever seen someone promise API stability for their raw Git repository 😅

But in all seriousness, I don't think should ever be an argument to create new branches or avoid refactorings in a particular branch. People who use sources directly from Git are intentionally not using any releases, so the promises we try to uphold for our releases also don't apply there.

@dyc3
Copy link
Contributor

dyc3 commented Jan 11, 2025

IMO, anyone using git sources without pinning to a specific commit is in for a bad time. Perhaps it would be better to have a more concrete discussion on versioning, maintenance, and branches to decide what exactly we want to do going forward.

@ematipico
Copy link
Member Author

ematipico commented Jan 13, 2025

Regardless, I am not ready to merge next to main, as I am still testing knope, and there are still few bugs that aren't fixed. I can't get the artefacts published in the releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants