-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add the includes field #4899
base: next
Are you sure you want to change the base?
Conversation
8848003
to
6b34864
Compare
6b34864
to
53f9da6
Compare
CodSpeed Performance ReportMerging #4899 will improve performances by 7.48%Comparing Summary
Benchmarks breakdown
|
53f9da6
to
d4f8b93
Compare
While I am testing the change, I noted some issues with our way of handling paths. Given the following hierarchy:
Biome will provide different paths to the glob matcher according to the command:
This was not causing any issue with We have to normalize the path provided on the CLI in order to solve the issue. I don't know how this affects our LSP. |
Summary
Part of #4611
This PR adds the
includes
field.This PR is not a breaking change because I didn't remove
include
andignore
.I leave the removal of
include
andignore
to another PR.I also started a migration rule and decided to leave it for another PR.
I noted a minor "caveat": when we replace
ignore
withincludes
we have to add an include pattern to ensure that some files got processed.For example, the following config:
Have to be rewritten as:
I think it is fine.
Test Plan
I replaced all occurrences of
include
andignore
byincludes
in the tests.