Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): export_named_type should parse default as normal #4903

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

fireairforce
Copy link
Member

closes: #4765

Summary

The following code:

export { type default as CrsMeta } from './crs-meta.js'

it should be parsed without error.

I just add a simple judge when parser meet T![default], and deal this to type alias, so it can be parsed successfully.

Test Plan

i add test case.

@github-actions github-actions bot added A-Parser Area: parser L-JavaScript Language: JavaScript and super languages labels Jan 17, 2025
Copy link

codspeed-hq bot commented Jan 17, 2025

CodSpeed Performance Report

Merging #4903 will improve performances by 7.15%

Comparing fix-4765 (293ba94) with next (4f07cc8)

Summary

⚡ 1 improvements
✅ 94 untouched benchmarks

Benchmarks breakdown

Benchmark next fix-4765 Change
react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +7.15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant