Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade rust to v1.84.0 #4910

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from
Draft

Conversation

unvalley
Copy link
Member

Summary

This PR upgrades rust (v1.84.0), fixes clippy errors and format.
Since I'd like to do the clippy fixes in the next branch, the direction was set as the next branch.

Test Plan

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages A-Diagnostic Area: diagnostocis L-HTML Language: HTML L-Grit Language: GritQL labels Jan 18, 2025
Copy link

codspeed-hq bot commented Jan 18, 2025

CodSpeed Performance Report

Merging #4910 will improve performances by ×140,000

Comparing unvalley:rust-1.84.0 (080246c) with next (4f07cc8)

Summary

⚡ 11 improvements
✅ 84 untouched benchmarks

Benchmarks breakdown

Benchmark next unvalley:rust-1.84.0 Change
css_analyzer[bootstrap_18416142857265205439.css] 216,151.4 µs 4.5 µs ×48,000
css_analyzer[bulma_5641719244145477318.css] 617,441.6 µs 4.5 µs ×140,000
css_analyzer[foundation_11602414662825430680.css] 147,265.7 µs 4.5 µs ×33,000
css_analyzer[tachyons_11778168428173736564.css] 120,465.4 µs 4.5 µs ×27,000
js_analyzer[css_16118272471217147034.js] 18,918 µs 35.3 µs ×540
js_analyzer[index_3894593175024091846.js] 45,888.8 µs 35.4 µs ×1,300
js_analyzer[lint_13640784270757307929.ts] 35,534.5 µs 38.3 µs ×930
js_analyzer[parser_13571644119461115204.ts] 65,636.3 µs 35.4 µs ×1,900
js_analyzer[router_17129688031671448157.ts] 19,122.8 µs 35.3 µs ×540
js_analyzer[statement_263793315104667298.ts] 60,859.6 µs 35.3 µs ×1,700
js_analyzer[typescript_3735799142832611563.ts] 98,719.8 µs 35.3 µs ×2,800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-Diagnostic Area: diagnostocis A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project A-Tooling Area: internal tools L-CSS Language: CSS L-Grit Language: GritQL L-HTML Language: HTML L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant