build: upgrade to Rust 2024 edition #5224
Draft
+260
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-CLI
# Conflicts: # Cargo.toml
# Conflicts: # Cargo.toml
siketyan
force-pushed
the
build/rust-2024
branch
from
4359d9d to
fe24394
Compare
siketyan
commented
Mar 1, 2025
Comment on lines
+331
to
+336
| ($least_expanded:expr, $($tail:expr),+ $(,)?) => { | ||
| // FIXME: Using any block in this macro causes a "temporary value dropped while borrowed" | ||
| // (E0716) error since Rust 2024 edition. It seems temporary lifetime extension is | ||
| // not working correctly, so it is a compiler bug? | ||
| $crate::macros::__macro_helper::best_fitting($crate::format_args!($least_expanded, $($tail),+)) | ||
| }; |
siketyan
force-pushed
the
build/rust-2024
branch
from
fe24394 to
f2d4776
Compare
CodSpeed Performance ReportMerging #5224 will improve performances by 6.08%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5196
Test Plan
Existing tests should pass.