refactor(js_analyze): remove support for dynamic regexes #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
Conaclos
force-pushed
the
conaclos/remove-dynamic-regex-support
branch
from
bd75a78 to
7aafac9
Compare
CodSpeed Performance ReportMerging #5226 will not alter performanceComparing Summary
|
ematipico
approved these changes
Mar 1, 2025
Conaclos
force-pushed
the
conaclos/remove-dynamic-regex-support
branch
from
7aafac9 to
68fdc34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes support for dynamically built regexes for the lint rules
noControlCharactersInRegexandnoMisleadingCharacterClass.This allows us to simplify the rules and avoid half-backed support.
Also, this makes these rules more consistent with other rules related to regexes.
Test Plan
I updated the tests and snapshots