Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #23

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Upgrade dependencies #23

merged 7 commits into from
Aug 28, 2023

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Aug 28, 2023

Depends on #22

@ArnyminerZ ArnyminerZ added the refactoring Quality improvement of existing functions label Aug 28, 2023
@ArnyminerZ ArnyminerZ self-assigned this Aug 28, 2023
@ArnyminerZ ArnyminerZ marked this pull request as ready for review August 28, 2023 10:07
@ArnyminerZ ArnyminerZ requested review from rfc2822 and removed request for rfc2822 August 28, 2023 10:07
@ArnyminerZ ArnyminerZ marked this pull request as draft August 28, 2023 10:12
@rfc2822 rfc2822 marked this pull request as ready for review August 28, 2023 10:14
@rfc2822 rfc2822 self-requested a review August 28, 2023 10:14
@rfc2822
Copy link
Member

rfc2822 commented Aug 28, 2023

Ah it doesn't build

@rfc2822 rfc2822 marked this pull request as draft August 28, 2023 10:14
Signed-off-by: Arnau Mora <[email protected]>
@ArnyminerZ
Copy link
Member Author

Ah it doesn't build

Yeah, it seems like Dokka is not updated yet. However we can keep the version to 1.8.20, it builds the documentation for me without any issues.

@ArnyminerZ ArnyminerZ marked this pull request as ready for review August 28, 2023 10:23
@ArnyminerZ ArnyminerZ marked this pull request as draft August 28, 2023 10:35
@rfc2822
Copy link
Member

rfc2822 commented Aug 28, 2023

Looks good, please set to Ready when ready for final review

@ArnyminerZ ArnyminerZ marked this pull request as ready for review August 28, 2023 18:36
@rfc2822 rfc2822 merged commit 21fda63 into main Aug 28, 2023
4 checks passed
@rfc2822 rfc2822 deleted the upgrade-dependencies branch August 28, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Quality improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants