Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add command goose update to update goose CLI version #1308

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

inmzhang
Copy link

No description provided.

@cloudripper
Copy link

cloudripper commented Feb 20, 2025

This is a valuable addition. To enhance build configurations for immutable systems, perhaps we could introduce an environment variable (e.g., DISABLE_CLI_UPDATES) that allows users to opt out of and disable CLI-based updates.

@inmzhang
Copy link
Author

This is a valuable addition. To enhance build configurations for immutable systems, perhaps we could introduce an environment variable (e.g., DISABLE_CLI_UPDATES) that allows users to opt out of and disable CLI-based updates.

Thanks for the suggestion. I'm not familiar with immutable systems, so not sure it's better to skip the update silently or raise an error when DISABLE_CLI_UPDATES is set. Currently, the latter is implemented.

@cliffhall
Copy link

I just want to duck my head in here and vote for this one. I have a ./update_goose.sh that I run all the time, but yes, this really seems like the right way for updates to happen.

@inmzhang inmzhang changed the title Add command goose update to update goose CLI version feat: Add command goose update to update goose CLI version Feb 21, 2025
Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the check for DISABLE_CLI_UPDATES as I think it makes sense not to need to check if the user is running an explicit goose update command.

Then good to merge. Thanks for the contribution!

@inmzhang
Copy link
Author

Hi Alex, thanks for the review. The change is applied, waiting for approval of CI checks...

@salman1993
Copy link
Collaborator

salman1993 commented Feb 26, 2025

thanks for contributing! the formatting check is failing - cargo fmt should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants