Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Cargo.lock file #942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amackillop
Copy link

In general, the Cargo.lock file should be included for applications and excluded for libraries.

For fun I also asked goose:

( O)> Should a Cargo.lock file be included in this project?

...

Yes, a Cargo.lock file should definitely be included in this project. Here's why:

1. This is a Rust project with multiple crates in a workspace structure
2. Currently there is no Cargo.lock file present
3. According to Rust best practices:
   - For binary projects (which this appears to be, given the CLI component), Cargo.lock SHOULD be committed to version control
   - Even for library projects, when using a workspace structure, it's recommended to commit the Cargo.lock file to ensure consistent builds across the workspace

@amackillop amackillop mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant