Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix likes tab endlessly pagniating #7770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Feb 18, 2025

Fixes #4879 #4931 #6179

I believe this is an error on the server side - it returns a cursor even when there are no more results. This is easy enough to detect and fix clientside, so let's do that.

Test plan

Check the likes tab on an account with no or few likes

Copy link

Old size New size Diff
7.02 MB 7.02 MB 39 B (0.00%)

@surfdude29
Copy link
Contributor

Fixes #4879
Fixes #4931
Fixes #6179

🙌

Also FYI there's some detailed investigation in #4879, including in this comment:

#4879 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewing Likes tab/page for an account/profile/user with no liked posts causes infinite spinner/loop XHR [web]
3 participants