-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New reporting flow #7832
Open
estrattonbailey
wants to merge
16
commits into
main
Choose a base branch
from
labeler-dec/base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New reporting flow #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new reporting flow that will power new functionality defined by labelers:
account
,record
andchat
app.bsky.feed.post
but notapp.bsky.feed.generator
By default, and for backwards compat, if labelers do not declare settings for any of these, we assume they support them all. So if you run this PR right now, the report options should be exactly the same as they are in production, just in a new format.
And yes we opted to encourage users to submit to a single labeler at a time, since once these new lexicons roll out, users should have far fewer options to report to. Most atm will likely only route to Bluesky's moderation service.
Normal reporting flow:
CleanShot.2025-02-24.at.14.45.55.mp4
Reporting content with only one labeler available, auto-selects this labeler (in this case an account, but could be any record):
CleanShot.2025-02-24.at.14.46.21.mp4
Reporting other types of content e.g. feeds, lists:
CleanShot.2025-02-24.at.14.46.42.mp4
Submission error state

Additional details expanded (also happens if Other is selected as report option):

Should-be-impossible scenario that there are no labelers available:

Initial loading state:

Initial load of labelers fails:

Developer error, passed in an object that can't be reported (should catch this in dev, but added a graceful fallback anyway)
