Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New reporting flow #7832

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

New reporting flow #7832

wants to merge 16 commits into from

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Feb 24, 2025

This PR introduces a new reporting flow that will power new functionality defined by labelers:

  • labelers will declare which report reasons they support e.g. spam, sexual, etc
  • labelers will declare what types of subjects they support e.g. account, record and chat
  • labelers will declare what NSID collections they support e.g. app.bsky.feed.post but not app.bsky.feed.generator

By default, and for backwards compat, if labelers do not declare settings for any of these, we assume they support them all. So if you run this PR right now, the report options should be exactly the same as they are in production, just in a new format.

And yes we opted to encourage users to submit to a single labeler at a time, since once these new lexicons roll out, users should have far fewer options to report to. Most atm will likely only route to Bluesky's moderation service.

Normal reporting flow:

CleanShot.2025-02-24.at.14.45.55.mp4

Reporting content with only one labeler available, auto-selects this labeler (in this case an account, but could be any record):

CleanShot.2025-02-24.at.14.46.21.mp4

Reporting other types of content e.g. feeds, lists:

CleanShot.2025-02-24.at.14.46.42.mp4

Submission error state
CleanShot 2025-02-24 at 14 49 54@2x

Additional details expanded (also happens if Other is selected as report option):
CleanShot 2025-02-24 at 14 49 15@2x

Should-be-impossible scenario that there are no labelers available:
CleanShot 2025-02-24 at 14 48 49@2x

Initial loading state:
CleanShot 2025-02-24 at 14 47 59@2x

Initial load of labelers fails:
CleanShot 2025-02-24 at 14 48 17@2x

Developer error, passed in an object that can't be reported (should catch this in dev, but added a graceful fallback anyway)
CleanShot 2025-02-24 at 14 47 46@2x

Copy link

Old size New size Diff
6.94 MB 6.94 MB 8.54 KB (0.12%)

@estrattonbailey estrattonbailey marked this pull request as ready for review February 24, 2025 21:05
@mozzius
Copy link
Member

mozzius commented Feb 24, 2025

Light mode is a little odd... maybe it's too monochrome? maybe the circle bit for the active one should be blue?

Screenshot 2025-02-24 at 21 33 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants