JBRULES-1731: RuleAgent has some outstanding FIXME items in RuleAgent…

…Test - specifically for windows git-svn-id: http://anonsvn.jboss.org/repos/labs/labs/jbossrules/trunk@21622 c60d74c8-e8f6-0310-9e8f-d4a2fc68ab70
bobmcwhirter · Aug 19, 2008 · fff79ee · fff79ee
1 parent ad2161b
commit fff79ee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/drools-compiler/.classpath b/drools-compiler/.classpath
@@ -5,10 +5,10 @@
   <classpathentry kind="src" path="src/test/resources" output="target/test-classes" excluding="**/*.java"/>
   <classpathentry kind="output" path="target/classes"/>
   <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
-  <classpathentry kind="var" path="M2_REPO/com/thoughtworks/xstream/xstream/1.2.2/xstream-1.2.2.jar"/>
+  <classpathentry kind="var" path="M2_REPO/com/thoughtworks/xstream/xstream/1.2.2/xstream-1.2.2.jar" sourcepath="M2_REPO/com/thoughtworks/xstream/xstream/1.2.2/xstream-1.2.2-sources.jar"/>
   <classpathentry kind="var" path="M2_REPO/xpp3/xpp3_min/1.1.3.4.O/xpp3_min-1.1.3.4.O.jar"/>
   <classpathentry kind="var" path="M2_REPO/janino/janino/2.5.10/janino-2.5.10.jar"/>
-  <classpathentry kind="var" path="M2_REPO/junit/junit/3.8.1/junit-3.8.1.jar"/>
+  <classpathentry kind="var" path="M2_REPO/junit/junit/3.8.1/junit-3.8.1.jar" sourcepath="M2_REPO/junit/junit/3.8.1/junit-3.8.1-sources.jar"/>
   <classpathentry kind="var" path="M2_REPO/org/antlr/antlr-runtime/3.0.1/antlr-runtime-3.0.1.jar"/>
   <classpathentry kind="var" path="M2_REPO/org/antlr/stringtemplate/3.1-b1/stringtemplate-3.1-b1.jar"/>
   <classpathentry kind="var" path="M2_REPO/org/antlr/gunit/1.0.1/gunit-1.0.1.jar"/>

diff --git a/drools-compiler/src/main/java/org/drools/compiler/SourcePackageProvider.java b/drools-compiler/src/main/java/org/drools/compiler/SourcePackageProvider.java
@@ -11,8 +11,9 @@
 
 /**
  * This is used by the agent when a source file is encountered.
+ * 
  * @author michaelneale
- *
+ * 
  */
 public class SourcePackageProvider implements FileLoader {
 
@@ -22,19 +23,19 @@ public Package loadPackage(File drl) throws IOException {
 		PackageBuilder b = new PackageBuilder();
 		try {
 			b.addPackageFromDrl(new InputStreamReader(fin));
+
+			fin.close();
+
 			if (b.hasErrors()) {
-				throw new RuntimeDroolsException("Error building rules from source: " + b.getErrors());
+				throw new RuntimeDroolsException(
+						"Error building rules from source: " + b.getErrors());
 			} else {
 				return b.getPackage();
 			}
 		} catch (DroolsParserException e) {
 			throw new RuntimeException(e);
 		}
 
-
-
 	}
 
-
-
 }