Skip to content
This repository has been archived by the owner on Apr 5, 2018. It is now read-only.

Adding ability to merge tags #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding ability to merge tags #3

wants to merge 1 commit into from

Conversation

pichot
Copy link

@pichot pichot commented Jul 21, 2016

Hello!

Wanted to put this here for your thoughts. A client project needed the ability to merge tags, instead of just renaming them. I thought it might be a useful feature for others since Craft allows tags to have the same string.

The merge implementation was straightforward thanks to a merge function on ElementsService. But I did have trouble getting the dropdown menu of tags to work as expected. The issue came down to the fact that I add tags to a list with jQuery when the menu is displayed. I couldn't find how to get Craft's click handlers to stick, and instead had to write my own.

I'd appreciate your thoughts on improvements, and if you think this is something you'd be interested in merging. Thanks!

@boboldehampsink
Copy link
Owner

Needs some work, but this sure is interesting. I'll have a closer look.

@pichot
Copy link
Author

pichot commented Jul 22, 2016

Great! Ya, feel free to point me in a better direction, particularly in terms of the js implementation, but I'd appreciate any other thoughts you might have.

@green-plastic
Copy link

Will this get implemented into the plugin at all?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants