Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to make this package useful for me #24

Merged
merged 8 commits into from
Apr 30, 2023

Conversation

williamatpaper
Copy link
Contributor

In this PR I have added variables to support the following:

  1. Allow the ability to change the "include_all" flag that the API uses to include all test cases when a new test run is created.
  2. Allow the ability to include all failed screenshots to be sent to testrail, instead of just the last one.
  3. Fixed an issue that prevents failed screenshots from being uploaded at all.

@williamatpaper
Copy link
Contributor Author

I could use some help verifying all my changes work @boxblinkracer :)

@boxblinkracer
Copy link
Owner

hi there
this is amazing, thank you
i've just approved the pipeline for you
please give me a few days for the review (really busy at the moment)

@williamatpaper
Copy link
Contributor Author

@boxblinkracer linted the PR, lmk if you can approve the pipeline again :)

@boxblinkracer
Copy link
Owner

aaand its green
thank you for this
i will take time and check it out soon :)

@williamatpaper
Copy link
Contributor Author

Thanks @boxblinkracer! Appreciate your responsiveness here!

@boxblinkracer
Copy link
Owner

Hi @williamatpaper
thank you so much
it looks great, pipeline is green, perfect
i will merge it.
just to let you know,...it could be that i rename the config keys in JSON...pretty long names, maybe i can come up with sth shorter,
but really good and thank you so much for your help on this :)

@boxblinkracer boxblinkracer merged commit cdcffdb into boxblinkracer:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants