Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .replace to omit commas in the array of case IDs #25

Merged
merged 1 commit into from
May 10, 2023

Conversation

asalgado87
Copy link
Contributor

Commas are being included in some of the case ID strings, causing a 400 response from testrail. I've tested this change on my machine and this fixes the issue.

…eing included in some of the case ID strings, causing a 400 response from testrail.
@boxblinkracer
Copy link
Owner

hi
thank you so much for this
do you know whey they are added? do you have a sample test-description where that happens?
is this then a bug in the extractor of case ids?

@asalgado87
Copy link
Contributor Author

I actually found that someone in our org had included commas separating test case ids.
example: 'C1234, C1235, C1236: test case example title'

So it turns out there was an issue with mapping on our side, not an actual bug.
This change will provide a guardrail in such a case but isn't totally necessary.
I found this out after putting up the pr so apologies for the unnecessary noise.

@boxblinkracer
Copy link
Owner

Hi
aaaa, got it :)
no worries regarding the noise,....with your PR its now more bulletproof
so im more than happy to merge it

thank you so much

@boxblinkracer boxblinkracer merged commit 4f90c84 into boxblinkracer:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants