Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra spaces after element #55

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

abdul99ahad
Copy link
Contributor

Closes #47

Proposed Changes

  • No extra spaces after element

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 2, 2024
@nikku
Copy link
Member

nikku commented Sep 10, 2024

Let's ensure this fix is accompanied by a test case.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 10, 2024
@philippfromme
Copy link
Contributor

What is the state of this PR @abdul99ahad? Is it ready for another review?

@abdul99ahad abdul99ahad marked this pull request as draft September 18, 2024 15:04
@abdul99ahad
Copy link
Contributor Author

What is the state of this PR @abdul99ahad? Is it ready for another review?

Not yet. Waiting for #59 approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently worked on
Development

Successfully merging this pull request may close these issues.

Empty grid point behind task with boundary event
3 participants