Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YNAB budget when there is only one budget id #586

Conversation

baruchiro
Copy link
Collaborator

Copy of #585 but for #579

@brafdlog
Copy link
Owner

Hey
Thanks for the PR!
Regarding the formatting, when there are formatting changes like this, please do them in a separate commit, as it makes it hard to see what are the actual changes you want vs just formatting.
Also, why are you changing the formatting?

@brafdlog
Copy link
Owner

I made a related fix here: b647136
Not sure why I don't see it in the code

@baruchiro
Copy link
Collaborator Author

@brafdlog I made a mistake in this PR. I created a PR from one branch into two target branches: master and vite-electron-builder. Now we need to merge the vite-electron-builder into the PR branch.

And this is why you can't see your change, because there is a conflict.

But your code is there. If it solves the problem, please close this PR.

@brafdlog
Copy link
Owner

@shaiu if you take a build from brafdlog:vite-electron-builder so you still experience the bug?

@brafdlog
Copy link
Owner

@brafdlog I made a mistake in this PR. I created a PR from one branch into two target branches: master and vite-electron-builder. Now we need to merge the vite-electron-builder into the PR branch.

And this is why you can't see your change, because there is a conflict.

But your code is there. If it solves the problem, please close this PR.

Just saw this.
It should solve the bug, @shaiu if it doesn't feel free to reopen

@brafdlog brafdlog closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants