Update to the latest image crate #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resizer should attempt to fit the resize into the desired size. One way to do this, if the first attempt does not succeed, is to keep trying by lowering the quality until we hit a pre-defined floor of 15. Return the same error as before if even that doesn't work.
wasm-thumbnail/src/lib.rs
Outdated
|
|
||
| let mut mquality = nquality; | ||
|
|
||
| while mquality >= 15 { |
There was a problem hiding this comment.
So this is definitely an improvement, but I think we could theoretically still not manage to create a small enough image for the size. (maybe for a massive resolution noisy image, with a small nsize).
There was a problem hiding this comment.
Yes, but if we've made ~17 attempts to resize the image and failed, I think it's fair to fall back to previous behavior and have the external program notify the user that a different set of parameters is required, (smaller rez, different image, etc)
tackley
reviewed
Jan 5, 2024
tackley
approved these changes
Jan 16, 2024
tsmartt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/brave-intl/creators-private-issues/issues/1754
This PR started as work to add looping into the library so that we could iteratively reduce the quality until the resized image would fit into the requested bytes, throwing an exception if we couldn't do it. Instead, we'll add that work to the rust service calling it, and just update the crate for now. Note that we investigated adding avif-decode support, and could do it if we didn't need to also compile to wasm. As it stands, libC support is not fully baked for the rust wasm compiler, so we'll need to hold off for now.