Use semicolon as file path separator for lua_load #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview for conkyweb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Caellian
added
enhancement
Caellian
force-pushed
the
fix/lua-load-separator
branch
from
d52a0fd to
f9a3134
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
fix/lua-load-separator
branch
from
f9a3134 to
5b95330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lua_loadpreviously expected space separated list of file names.As spaces in file names do happen even to most experienced GNU+Linux users, I made
lua_loadhandle;separators on top of space separators.Basically, if string contains
;, new logic will be used, if not, old logic will be used. Additionally, empty paths are skipped.This allows for values like
./my file has spaces.lua;which would've been impossible to load previously.As the fallback is space separator, this shouldn't break existing configs that use multiple files already. I added a TODO for 2028 to remove the branch for old behavior.
Lastly, previous code did a lot of copies and moves, new code doesn't.