Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broccoli 3 #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Broccoli 3 #27

wants to merge 2 commits into from

Conversation

kellyselden
Copy link

@kellyselden kellyselden commented Nov 16, 2020

I ran yarn why broccoli on my monorepo, and everything is using broccoli 3 except this. I thought it would be nice to get it consistent, and might even resolve an issue we are having with yarn resolutions.

Kelly Selden added 2 commits November 16, 2020 17:30
in preparation of broccoli 3's node 8 requirement
Copy link
Contributor

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@lifeart
Copy link

lifeart commented Oct 18, 2021

@rwjblue could we land it?

I'm planning to update other deps

@LucasHillDex
Copy link

@kellyselden this is old but broccoli 2 is bringing in dependencies with vulnerabilities into our project that would be amazing to eject!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants