add o1 to model #372
Open
add o1 to model #372
+86
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d63c666 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kamath
reviewed
Jan 4, 2025
| @@ -100,9 +100,19 @@ export class OpenAIClient extends LLMClient { | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| if (this.modelName === "o1") { | |||
| delete options.temperature; | |||
There was a problem hiding this comment.
can we instead do something like:
{ temperature, top_p, frequency_penalty, presence_penalty, ...options } = options
then we can log each as being removed since model is o1
kamath
reviewed
Jan 4, 2025
| @@ -0,0 +1,33 @@ | |||
| import { test, expect } from "@playwright/test"; | |||
There was a problem hiding this comment.
this isn't a deterministic test, this directory is for e2e tests that don't leverage AI at all. this would be a better fit going in evals/tasks, and adding the combination label in evals.config.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
what changed
add o1 to list of supported models
test plan
tested using example