Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim excess threads onSend #2148

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Trim excess threads onSend #2148

wants to merge 1 commit into from
+4 −1

Conversation

YYChen01988
Copy link
Contributor

@YYChen01988 YYChen01988 commented Feb 17, 2025 •
edited
Loading

Goal

Trim event threads if the size is too large

Design

Threads are now be trimmed less equal config maxReportedThreads in EventPayload

Testing

Existing tests

@YYChen01988 YYChen01988 requested a review from lemnik as a code owner February 17, 2025 15:30
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Feb 17, 2025 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1872.0 1675.18
arm64_v8a 651.52 450.82
armeabi_v7a 585.99 385.29
x86 725.23 528.62
x86_64 696.57 495.86

Generated by 🚫 Danger

@lemnik lemnik changed the title trim threads size Trim excess threads onSend Feb 18, 2025
@YYChen01988 YYChen01988 force-pushed the PLAT-13360/trim-ExitInfo-payload-size branch from 5e6a607 to 2d05bc2 Compare February 18, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik Awaiting requested review from lemnik lemnik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YYChen01988 @bugsnagbot @lemnik