Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard eventbridge fields to the example payloads #2942

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

amu-g
Copy link
Contributor

@amu-g amu-g commented Aug 21, 2024

The example payloads for eventbridge events only showed fields that buildkite varies. As raised in #2935, copy and pasting this into the eventbridge sandbox as-is results in an error message that the sample event is not valid.
Putting the full payload in the examples will make it easier for users to test patterns using the eventbridge sandbox.

The example payloads for eventbridge events only showed fields that buildkite varies. Copy and
pasting this into the eventbridge sandbox as-is results in an error message that the sample
event is not valid.
Putting the full payload in the examples will make it easier for users to test patterns using the
eventbridge sandbox.
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2942--bk-docs-preview.netlify.app

@gilesgas
Copy link
Contributor

Thank you very much for this @amu-g ! 🎉

Just to clarify, does this PR now supersede #2935?

@amu-g
Copy link
Contributor Author

amu-g commented Aug 21, 2024

yes, it does @gilesgas

Copy link
Contributor

@gilesgas gilesgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming @amu-g !

Ready for you to merge this in :-) (I just pushed up a fix to one of the headings on the page.)

@amu-g amu-g merged commit b34e97e into main Aug 22, 2024
3 checks passed
@amu-g amu-g deleted the amug/eventbridge branch August 22, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants