Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PKG-7403] - API docs for registries create #2968

Merged
merged 4 commits into from
Sep 12, 2024
Merged

[PKG-7403] - API docs for registries create #2968

merged 4 commits into from
Sep 12, 2024

Conversation

ensvo
Copy link
Contributor

@ensvo ensvo commented Sep 11, 2024 •
edited by gilesgas
Loading

image image

@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2968--bk-docs-preview.netlify.app

@ensvo ensvo mentioned this pull request Sep 11, 2024
Merged
@ensvo ensvo force-pushed the ev-packages-api-registry-show branch from edc77aa to e0172bf Compare September 11, 2024 07:47
@ensvo ensvo force-pushed the ev-packages-api-registry-create branch from 49e5edd to 77f9ad5 Compare September 11, 2024 07:48
@swebb swebb requested a review from a team September 11, 2024 10:11
swebb
swebb approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@swebb swebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change but basically looks good 👍🏻

pages/apis/rest_api/packages/registries.md Outdated
</tbody>
</table>

Required scope: `create_registries`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_registries doesn't exist. I think this should be write_registries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

Base automatically changed from ev-packages-api-registry-show to main September 12, 2024 02:21
@gilesgas gilesgas merged commit 2fc4274 into main Sep 12, 2024
3 checks passed
@gilesgas gilesgas deleted the ev-packages-api-registry-create branch September 12, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilesgas gilesgas gilesgas approved these changes

@swebb swebb swebb approved these changes

Assignees
No one assigned
Labels
api rest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ensvo @buildkite-docs-bot @swebb @gilesgas