Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tablet): set rows grid to 0 if it's empty (e.g. no toc section) #3000

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

hannahcancode
Copy link
Contributor

  • on tablet, the screen is split into 4 grid areas: if there's no automatic TOC generated, which takes up the top right corner, and the content doesn't fill up the screen, the content ends up in the bottom left corner. If we add a minmax to the grid rows, with a min of 0 and a max of auto, it should sort itself out better.

After:
Screenshot 2024-10-28 at 1 53 18 PM

Before Reported by @zhming0:
Screenshot 2024-10-28 at 1 23 23 PM

@hannahcancode hannahcancode requested a review from a team as a code owner October 28, 2024 02:53
@buildkite-systems
Copy link

@buildkite-systems buildkite-systems merged commit 2ee135b into main Oct 28, 2024
3 checks passed
@buildkite-systems buildkite-systems deleted the fix-tablet-with-no-toc branch October 28, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants