-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous Explore tool improvements #8649
Open
lpereira
wants to merge
22
commits into
bytecodealliance:main
Choose a base branch
from
lpereira:explore-enhancements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a7a5bfe
Auto-format explorer index.js
lpereira 7bdb73f
Use CRC24 to pick colors for offsets in explore
lpereira 503f054
Make better use of the DOM
lpereira 83029d2
Draw polygon bridging WAT and ASM views
lpereira ed88016
Scale luma calculation to a power of two to avoid integer division
lpereira e831cc4
Outline hovered lines
lpereira 8d6be49
Adjust bridge width to account for different scrollbar widths
lpereira 2780e84
Use simpler math in rgbToLuma() to avoid multiplications too
lpereira be93ce6
Slight improvement to crc24 calculation
lpereira c78fbc9
Draw multiple conections from WAT to ASM views
lpereira 6a81603
Show WASM offset on hover in the ASM view
lpereira b938653
Fix grouping of ASM instructions
lpereira 3a212ec
Only set the title attribute to show WASM offset on hover
lpereira 401acda
Fix grouping of instructions in ASM mode
lpereira 0edd617
Add note about the origin of the CRC-24 calculation
lpereira 759a745
Tweak color generation (let some brighter colors pass the filter)
lpereira 2e4c3d9
Ensure we have enough elements to compute the bridge polygon
lpereira ea6cd9d
Don't obscure the hovered line with the outline
lpereira 3782a9b
Simplify bridge width calculation
lpereira 1de200e
Optimize hovering of blocks when one 1 WAT element matches with 1 ASM…
lpereira d0f6635
Address review comments
lpereira 0c9ee7c
Make eslint happy
lpereira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,17 @@ | ||
import js from "@eslint/js"; | ||
import globals from "globals"; | ||
import pluginJs from "@eslint/js"; | ||
|
||
export default [ | ||
js.configs.recommended, | ||
|
||
{ | ||
files: ["**/*.js"], | ||
languageOptions: { | ||
sourceType: "module", | ||
globals: globals.browser, | ||
}, | ||
rules: { | ||
"no-unused-vars": "error", | ||
"no-undef": "error", | ||
}, | ||
}, | ||
pluginJs.configs.recommended, | ||
]; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this?