#7954 alias analysis attempt #9213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed:
modified: cranelift/codegen/src/alias_analysis.rs: Use
dominator tree
modified: cranelift/codegen/src/context.rs: Use dominator tree
modified: cranelift/codegen/src/dominator_tree.rs: Fix
dominates and computes and modify logic of domination
github-actions
bot
added
the
cranelift
elliottt
reviewed
Sep 17, 2024
Comment on lines
+442
to
+448
|
|
||
| /// Clear the data structure | ||
| /// Recursively clears its underlying children | ||
| pub fn clear(&mut self) { | ||
| self.nodes.clear(); | ||
| self.stack.clear(); | ||
| } |
There was a problem hiding this comment.
Is this function still needed? It doesn't look like it's referenced from the changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #7954, attempted in #8535, reattempted in this pr.
Draft first for ci pipeline. Possible rebase for better commit msg