Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): should respect model's factors config #159

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

ulivz
Copy link
Collaborator

@ulivz ulivz commented Feb 27, 2025

This pull request includes important updates to the packages/sdk module, focusing on improving the UITarsModel class and enhancing type exports. The most significant changes involve modifying the factor parameter usage and adding a new type export for better type management.

Key changes include:

Improvements to UITarsModel:

  • packages/sdk/src/Model.ts: Updated the factor parameter in the actionParser call to use this.factors instead of the constant FACTORS.

Enhancements to type exports:

  • packages/sdk/src/core.ts: Added a new type export for UITarsModelConfig to improve type management and usage across the module.

ycjcl868
ycjcl868 previously approved these changes Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.63%. Comparing base (83f0bc6) to head (e60c8dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   24.63%   24.63%           
=======================================
  Files          69       69           
  Lines        1514     1514           
  Branches      238      238           
=======================================
  Hits          373      373           
  Misses       1096     1096           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ycjcl868 ycjcl868 merged commit 9c5f8f4 into main Feb 27, 2025
10 checks passed
@ycjcl868 ycjcl868 deleted the feat/refactor-sdk-model branch February 27, 2025 14:16
@ycjcl868
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants