add more debug info for TypeInfoConverter

[beyond-up]

#417

Signed-off-by:

Pre-Checklist

Note: Please complete ALL items in the following checklist.

• I have read through the CONTRIBUTING.md documentation.
• My code has the necessary comments and documentation (if needed).
• I have added relevant tests.

Purpose

add more debug info and add check null for TypeInfoConverter

Related Issues

(#417)

New Behavior (screenshots if needed)

N/A

[hk-lrzy]

@beyond-up Can we add more check after the code both in the NativeFlinkTypeInfoUtil and ColumnFlinkTypeInfoUtil

  public static RowTypeInfo getRowTypeInformation(List<ColumnInfo> columnInfos,
                                                  TypeInfoConverter typeInfoConverter) {

    String[] fieldNames = new String[columnInfos.size()];
    TypeInformation<?>[] fieldTypes = new TypeInformation[columnInfos.size()];

    for (int index = 0; index < columnInfos.size(); index++) {
      String type = StringUtils.lowerCase(columnInfos.get(index).getType());
      String name = columnInfos.get(index).getName();

      TypeInfo<?> typeInfo = typeInfoConverter.fromTypeString(type);

      //in here
      fieldNames[index] = name;
      fieldTypes[index] = toNativeFlinkTypeInformation(typeInfo);
    }

    return new RowTypeInfo(fieldTypes, fieldNames);
  }

Not every new type converter has enough validation rules, so add validation check after the typeInfoConverter invoke maybe more make sense? What do you think.

[hk-lrzy]

default:
throw new IllegalArgumentException(String.format("Non type match for the type: %s.", engineType));

maybe follow will be better because we will know the field name directly.

throw new BitSailException(String.format("Field {} has no type match for the type: %s.", fieldname, engineType));

[beyond-up]

ok, thanks

[hk-lrzy]

@beyond-up Good job, i will merge it after CICD.

[beyond-up]

@beyond-up Good job, i will merge it after CICD.

@hk-lrzy Thank you for your guidance and patience !