Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support golang 1.24 #741

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support golang 1.24 #741

wants to merge 2 commits into from

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Feb 13, 2025

Main Changes:

  1. adjust the GoMapIterator as Golang
  2. support omitzero field tag
  3. remove many duplicated linkname
  4. add go1.24 ci

NOTE: we are waiting go1.24.1 to solve the link name problem #738

@liuq19 liuq19 force-pushed the feat/go1.24 branch 3 times, most recently from e3aeec8 to b20b0be Compare February 13, 2025 11:11
@thrasher-
Copy link

Hey guys, any ETA on when go v1.24 will be supported?

@zchee
Copy link

zchee commented Feb 20, 2025

@thrasher- I'm NOT bytedance/sonic maintainer, but FYI:

So, we should wait for 1.24.1 next release I think.

@liuq19
Copy link
Collaborator Author

liuq19 commented Feb 20, 2025

Hey guys, any ETA on when go v1.24 will be supported?

we should wait for go1.24.1 to solve the linkname problem #738

@AsterDY
Copy link
Collaborator

AsterDY commented Feb 26, 2025

Fixes #735


func handleOmitZero(fv StdField, fm *FieldMeta) {
if fv.omitZero {
println("omit zero, field: ", fv.name)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has println

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants