Comment out requires to android native modules #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android expects the native library to be installed in
/lib/<abi>directory.That's why in the jars of native libraries the libraries are in
/lib/<abi>instead of the/org/bytedeco/<presets>/<system>-<abi>/path used for other platforms.So when using JPMS and bringing in the module graph the native jars of multiple presets for android, files in directory
/lib/<abi>are present in multiple modules, leading to a split package exception.Note that this only happens :
-into the module graph (problably using somerequires org.bytedeco.<preset>.platformin the applicationmodule-info.java). Since directories with a-are not considered java packages.This PR solves this problem by removing the dependencies of platform modules towards android native modules, so that the android native modules are never brought into the module graph when using the platform modules.
This shouldn't have side effects as long as Android doesn't support JPMS.
See Issue 814