Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap addPlugin() call in has() check. #983

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Wrap addPlugin() call in has() check. #983

merged 2 commits into from
Jul 2, 2024

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Apr 18, 2024

Cake 5.1 throws exception for duplicate plugin loading and this avoids exception if the TwigView plugin is already loaded from the application.

Cake 5.1 throws exception for duplicate plugin loading and this avoids
exception if the TwigView plugin is already loaded from the application.
@ADmad ADmad added this to the 3.x (CakePHP 5) milestone Apr 18, 2024
@ADmad
Copy link
Member Author

ADmad commented Apr 18, 2024

I have created a 3.next branch but this could safely go in 3.x too.

@ADmad ADmad requested review from markstory July 2, 2024 14:10
@markstory markstory merged commit 97e6077 into 3.next Jul 2, 2024
6 of 8 checks passed
@markstory markstory deleted the plugin-add branch July 2, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants