fix: iOS inverted tap-to-seek in RTL (#677)

callstack · Jan 17, 2025 · a0bb8b5 · a0bb8b5
1 parent 2f07d2d
commit a0bb8b5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/package/ios/RNCSliderComponentView.mm b/package/ios/RNCSliderComponentView.mm
@@ -77,7 +77,14 @@ - (void)tapHandler:(UITapGestureRecognizer *)gesture {
 
     CGPoint touchPoint = [gesture locationInView:slider];
     float rangeWidth = slider.maximumValue - slider.minimumValue;
-    float sliderPercent = touchPoint.x / slider.bounds.size.width;
+
+    float sliderPercent;
+    if ([UIView userInterfaceLayoutDirectionForSemanticContentAttribute:slider.semanticContentAttribute] == UIUserInterfaceLayoutDirectionRightToLeft) {
+        sliderPercent = 1.0 - (touchPoint.x / slider.bounds.size.width);
+    } else {
+        sliderPercent = touchPoint.x / slider.bounds.size.width;
+    }
+
     slider.lastValue = slider.value;
     float value = slider.minimumValue + (rangeWidth * sliderPercent);
 

diff --git a/package/ios/RNCSliderManager.m b/package/ios/RNCSliderManager.m
@@ -57,7 +57,14 @@ - (void)tapHandler:(UITapGestureRecognizer *)gesture {
 
   CGPoint touchPoint = [gesture locationInView:slider];
   float rangeWidth = slider.maximumValue - slider.minimumValue;
-  float sliderPercent = touchPoint.x / slider.bounds.size.width;
+
+  float sliderPercent;
+  if ([UIView userInterfaceLayoutDirectionForSemanticContentAttribute:slider.semanticContentAttribute] == UIUserInterfaceLayoutDirectionRightToLeft) {
+      sliderPercent = 1.0 - (touchPoint.x / slider.bounds.size.width);
+  } else {
+      sliderPercent = touchPoint.x / slider.bounds.size.width;
+  }
+
   slider.lastValue = slider.value;
   float value = slider.minimumValue + (rangeWidth * sliderPercent);