-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Touch Height for the ios device. #468
base: main
Are you sure you want to change the base?
Conversation
Please review my changes and accept my PR |
Update Slider.tsx
Update Slider.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand the reason of this change - does the default style created for iOS conflicts with the custom height for you?
@@ -285,7 +285,7 @@ SliderWithRef.defaultProps = { | |||
}; | |||
|
|||
let styles = StyleSheet.create( | |||
Platform.OS === 'ios' ? {slider: {height: 40}} : {slider: {}}, | |||
Platform.OS === 'ios' ? {slider: {}} : {slider: {}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With removing the height: 40
style, this line does actually nothing, and could even be simplified into:
Platform.OS === 'ios' ? {slider: {}} : {slider: {}}, | |
{slider: {}} |
Summary:
Test Plan:
I needed to customize the height of the touch area for the ios so i have made changes to the file.