-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom thumb's component with additional props #655
Custom thumb's component with additional props #655
Conversation
@BartoszKlonowski |
Yes, that is the goal of this PR. Although, need to mention that even with this PR it would still require using the |
@BartoszKlonowski |
6d8ce5f
to
43e67c4
Compare
This pull request closes #154
It implements additional possibilities of customizing the Slider's thumb component.
Including:
currentValue
so that the main, custom component can know it's current position.currentValue
to know whether it is pass or before the thumb ("filled" or "empty").What is still to be done before merging:
Although it can be done in separate issue, as the docs would already use some attention to improve readability, especially considering extended options of customization.
We currently render a lot each go, so it would be good to take a closer look
The example implemented for new addition behaves incorrectly on iOS (the left section of custom thumb changes the position each step. It blinks for a moment before correctly render).
Below is the short demo with the implemented example:
(iOS to the left, Android on the right)
154-custom-component.mp4