-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove {{}} in Optimize update guide links #4561
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
Oops, sorry for the misleading branch name. I also couldn't easily figure out where this content should point to, so I didn't include links. |
If this builds, this will take care of all the links in the docs.camunda.org syntax. However, there will still be instances where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these links resolve to the versioned docs? Right now, they're sending me to /next, and I am not sure of the Optimize versioned docs can figure out what version it's in without backing out of the current directory.
This does look like a bug. Given the links didn't resolve at all previously, but now go to a page that exists, I think it's a risk I'm willing to accept. Also these versions are technically too old to be supported and the C7 docs will move back to docs.camunda.org soon. Any concerns with my logic here @conceptualshark? |
👍 Works for me - happy to approve! |
🧹 Preview environment for this PR has been torn down. |
Description
Related to #2719, fixes build issues by getting docs.camunda.org syntax out.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).