Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connecting-the-workflow-engine-with-your-world.md #4571

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

berndruecker
Copy link
Member

@berndruecker berndruecker commented Nov 5, 2024

softened language around connectors and updated to improved connector infrastructure

From Slack

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

softened language around connectors and updated to improved connector infrastructure
Copy link
Contributor

github-actions bot commented Nov 5, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

sbuettner
sbuettner previously approved these changes Nov 5, 2024
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mesellings
Copy link
Contributor

@berndruecker Would you like a TW review on this?

@akeller
Copy link
Member

akeller commented Nov 5, 2024

@mesellings please, we'll also need to backport (forwardport, lol) to /next/. Can you take care of both the review and porting?

@mesellings mesellings self-requested a review November 5, 2024 14:20
@mesellings mesellings added component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR labels Nov 8, 2024
@github-actions github-actions bot temporarily deployed to camunda-docs November 8, 2024 09:58 Destroyed
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just made some edits to Connector/connector casing & slight rewording on line 218, and also 'forwardported' your changes to /next/ version docs 👍 🚀

@mesellings mesellings removed the deploy Stand up a temporary docs site with this PR label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🧹 Preview environment for this PR has been torn down.

@mesellings
Copy link
Contributor

@berndruecker Would you like me to merge and release this for you?

@akeller
Copy link
Member

akeller commented Nov 8, 2024

@berndruecker Would you like me to merge and release this for you?

I got it for him :)

@akeller akeller merged commit 38dd003 into main Nov 8, 2024
6 checks passed
@akeller akeller deleted the berndruecker-patch-1 branch November 8, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants