tests: run tests on master branch nightly #15084
Conversation
This change runs the tests using master branch nightly instead of after a change is pushed to master. We do that in order to reduce the amount of instances used in google. Also the nightly job was renamed to nightly-static-analysis which is a more representative name.
| systems: 'ALL' | ||
| tasks: 'tests/...' | ||
| rules: '' | ||
| use-snapd-snap-from-master: true |
There was a problem hiding this comment.
Don't we want to run all tests except for openstack? So not only the google backend, but also nested, arm, pro, and google-distro-*?
There was a problem hiding this comment.
If we want to effectively move the same thing from master to here, we could read the json files for fundamental and non-fundamental and run spread on those
There was a problem hiding this comment.
right, I just implemented what you suggested. Thanks for the review.
|
Wed Feb 19 09:42:41 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
This is because there are several google-* backends and doing this we simplify the workflow configuration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15084 +/- ##
=========================================
Coverage ? 78.06%
=========================================
Files ? 1185
Lines ? 157793
Branches ? 0
=========================================
Hits ? 123184
Misses ? 26958
Partials ? 7651
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I didn't think to mention that we no longer have the nested systems in the fundamental/non-fundamental divide so they have to be explicitly added. Sorry about that. I think that we can actually make things more compact anyway and have only one spread job (since there's no need to divide out the systems). Here's my suggestion:
read-systems:
runs-on: ubuntu-latest
outputs:
systems: ${{ steps.read-systems.outputs.systems }}
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Read matrix file
id: read-systems
shell: bash
run: |
fund="$(jq -c . ./.github/workflows/fundamental-systems.json)"
nonfund="$(jq -c . ./.github/workflows/non-fundamental-systems.json)"
all=$(echo "$fund $nonfund" | jq -s '[.[0].include, .[1].include] | flatten | {include: .}')
ubuntu18='{"group":"nested-ubuntu-18.04","backend":"google-nested","systems":"ubuntu-18.04-64","tasks":"tests/nested/...","rules":"nested"}'
ubuntu20='{"group":"nested-ubuntu-20.04","backend":"google-nested","systems":"ubuntu-20.04-64","tasks":"tests/nested/...","rules":"nested"}'
ubuntu22='{"group":"nested-ubuntu-22.04","backend":"google-nested","systems":"ubuntu-22.04-64","tasks":"tests/nested/...","rules":"nested"}'
ubuntu24='{"group":"nested-ubuntu-24.04","backend":"google-nested","systems":"ubuntu-24.04-64","tasks":"tests/nested/...","rules":"nested"}'
all=$(echo "$all $ubuntu18 $ubuntu20 $ubuntu22 $ubuntu24" | jq -s '.[0] * { include: (.[0].include + [.[1], .[2], .[3], .[4]]) }')
echo "systems=$(echo $all | jq -c)" >> $GITHUB_ENVSince it's a single output, then we would only need a single spread job to follow.
This change runs the tests using master branch nightly instead of after a change is pushed to master.
We do that in order to reduce the amount of instances used in google.
Also the nightly job was renamed to nightly-static-analysis which is a more representative name.