Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: drop unused check-syntax-c target #15085

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

bboozzoo
Copy link
Contributor

The target is no longer used anywhere.

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

The target is no longer used anywhere.

Signed-off-by: Maciej Borzecki <[email protected]>
@bboozzoo bboozzoo added Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run labels Feb 14, 2025
@bboozzoo bboozzoo requested review from zyga and miguelpires February 14, 2025 13:33
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (a272aac) to head (a1e1900).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15085      +/-   ##
==========================================
- Coverage   78.07%   78.06%   -0.01%     
==========================================
  Files        1182     1181       -1     
  Lines      157743   157740       -3     
==========================================
- Hits       123154   123146       -8     
- Misses      26943    26947       +4     
- Partials     7646     7647       +1     
Flag Coverage Δ
unittests 78.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miguelpires miguelpires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link

Fri Feb 14 15:03:55 UTC 2025

Spread tests skipped

@bboozzoo bboozzoo merged commit c64bfe9 into canonical:master Feb 17, 2025
75 checks passed
@bboozzoo bboozzoo deleted the bboozzoo/drop-unused-target branch February 17, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants