Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: install questionnaires via plugins #369

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: install questionnaires via plugins #369

wants to merge 9 commits into from

Conversation

jamagalhaes
Copy link
Collaborator

@jamagalhaes jamagalhaes commented Jan 28, 2025 •
edited by jira bot
Loading

aduane
aduane reviewed Jan 28, 2025
View reviewed changes
plugin_runner/tests/fixtures/plugins/test_load_questionnaire/protocols/my_protocol.py Outdated

from canvas_sdk.effects import Effect
from canvas_sdk.events import EventType
from canvas_sdk.protocols import BaseProtocol
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to start moving away from using BaseProtocol as a default, and instead using BaseHandler. They aren't different at the moment but they will be at some point, and in most cases BaseHandler will be more appropriate.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve once these get changed to inheriting from BaseHandler instead of from BaseProtocol

@jamagalhaes jamagalhaes force-pushed the feat/koala-2219-questionnaires branch from dbf5c73 to 0c8cf00 Compare January 30, 2025 14:23
@jamagalhaes
Copy link
Collaborator Author

@aduane / @kristenoneill I found this document: https://canvas-medical.help.usepylon.com/articles/7017593857-creating-questionnaires#building-a-questionnaire-1

and based on what we have here, we need to discuss which properties we want to drop or rename.

@jamagalhaes jamagalhaes force-pushed the feat/koala-2219-questionnaires branch 2 times, most recently from b5c3b72 to 36a566b Compare February 4, 2025 17:37
@jamagalhaes jamagalhaes force-pushed the feat/koala-2219-questionnaires branch from 36a566b to d4323a3 Compare February 4, 2025 17:49
@jamagalhaes jamagalhaes marked this pull request as ready for review February 4, 2025 19:14
@jamagalhaes jamagalhaes requested a review from a team as a code owner February 4, 2025 19:14
@jamagalhaes jamagalhaes requested a review from aduane February 5, 2025 19:47
@jamagalhaes jamagalhaes force-pushed the feat/koala-2219-questionnaires branch from 3f9684d to 15934d3 Compare February 6, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduane aduane aduane approved these changes

@nmpsilva nmpsilva Awaiting requested review from nmpsilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamagalhaes @aduane