Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SystemZ macro in Makefile #2603

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix SystemZ macro in Makefile #2603

merged 1 commit into from
Jan 28, 2025

Conversation

Changqing-JING
Copy link
Contributor

@Changqing-JING Changqing-JING commented Jan 15, 2025 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fix SystemZ is not correctly build by ./make.sh

Test plan

...

Closing issues

Rot127
Rot127 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please note though that we effectively deprecated the Makefile build in favor of cmake. So it is no longer maintained.

@Rot127
Copy link
Collaborator

Rot127 commented Jan 16, 2025

Please rebase onto the latest next branch to run the labeler again.

@Changqing-JING
Copy link
Contributor Author

Rebased

kabeor
kabeor approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, merged.

@kabeor kabeor merged commit c831cd5 into capstone-engine:next Jan 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rot127 Rot127 Rot127 approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Changqing-JING @Rot127 @kabeor