Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devops]: Remove references to internal/vendor packages #12010

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[devops]: Remove references to internal/vendor packages #12010

wants to merge 14 commits into from

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Sep 4, 2024

Related Ticket(s)

Closes #12008

Description

Adjusts all internal/vendor imports to use the package imports instead.

Changelog

Changed

  • All imports of the form [...]/internal/vendor/@carbon/[package][rest] changed to @carbon/[package]/es[rest]

Removed

  • vendor build steps

@m4olivei m4olivei added Feature request A new adopter requested feature adopter: AEM used when component or pattern will be used by this adopter owner: AEM owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants v2 labels Sep 4, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 4, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12010/index.html

Built with commit: e47e8c17a1faef713e3a51384ded928293744149

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 4, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12010/index.html

Built with commit: 5275b71534400d9f7867c9fe4682278c7dadf334

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 4, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12010/index.html

Built with commit: 5275b71534400d9f7867c9fe4682278c7dadf334

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 4, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12010/index.html

Built with commit: 5275b71534400d9f7867c9fe4682278c7dadf334

@m4olivei m4olivei marked this pull request as ready for review September 5, 2024 13:22
@m4olivei m4olivei requested a review from a team as a code owner September 5, 2024 13:23
@m4olivei m4olivei requested review from kennylam, annawen1, bruno-amorim, marcelojcs, andy-blum and Valentin-Sorin-Nicolae and removed request for a team September 5, 2024 13:23
@andy-blum andy-blum added test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing test: CWC CDN preview test: CDN preview used for generating @carbon/web-components CDN for testing labels Sep 5, 2024
@andy-blum andy-blum closed this Sep 5, 2024
@andy-blum andy-blum reopened this Sep 5, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 5, 2024 •
edited
Loading

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12010/index.html

Built with commit: 5275b71534400d9f7867c9fe4682278c7dadf334

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 5, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components Deploy Preview CDN:
https://carbon-web-components-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12010/index.html

Built with commit: 5275b71534400d9f7867c9fe4682278c7dadf334

andy-blum
andy-blum approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@andy-blum andy-blum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes all the tests, and I don't see any stragglers still importing from internal/vendor.

Even after yarn clean yarn install and yarn build, I am still seeing built files importing from those paths, but maybe that can be a followup?

@m4olivei
Copy link
Contributor Author

Passes all the tests, and I don't see any stragglers still importing from internal/vendor.

Even after yarn clean yarn install and yarn build, I am still seeing built files importing from those paths, but maybe that can be a followup?

I see one place where those are coming from. Fix incoming.

@m4olivei
Copy link
Contributor Author

Passes all the tests, and I don't see any stragglers still importing from internal/vendor.
Even after yarn clean yarn install and yarn build, I am still seeing built files importing from those paths, but maybe that can be a followup?

I see one place where those are coming from. Fix incoming.

Fixed in 86ef4f5. There was a build script for icons that was automating creation of modules that used an internal/vendor import path.

@andy-blum
Copy link
Member

Looks good - should we remove the documentation around the vendor dirs?

https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/main/packages/web-components/IMPLEMENTATION_NOTES.md#vendor-directory

@m4olivei
Copy link
Contributor Author

Looks good - should we remove the documentation around the vendor dirs?

https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/main/packages/web-components/IMPLEMENTATION_NOTES.md#vendor-directory

Addressed in e47e8c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-blum andy-blum andy-blum approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae Awaiting requested review from Valentin-Sorin-Nicolae

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter Feature request A new adopter requested feature owner: AEM owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing test: CWC CDN preview test: CDN preview used for generating @carbon/web-components CDN for testing v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[devops]: Remove references to internal/vendor packages
3 participants
@m4olivei @ibmdotcom-bot @andy-blum